Fix passthrough auth for users without a password #780
Fix passthrough auth for users without a password #780howenyap wants to merge 4 commits intopgdogdev:mainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Looks great! Quick ask, would you be able to add an integration test in Another thing, in if passthrough_password.is_some() {
conn.resume_cluster_pools();
}While this is quick and pretty harmless, I think we should still check if the pool already has a password set, i.e., another client connected already and we configured the auth and resumed the pool. I think you can do this quickly by checking the |
|
thanks for reviewing @levkk ! made changes as requested |
Closes #373
Logic change
Clusterwithnew_pool, pause the cluster if passthrough auth is enabled and password is emptyTestcases
test_passthrough_empty_password_starts_pausedfalsetruepausedtest_passthrough_user_with_password_unpausedfalsefalsenot pausedtest_passthrough_empty_password_trust_starts_unpausedtruetruenot pausedtest_replace_empty_password_cluster_with_passthrough_passwordtest_pause_resume_toggles_all_pools:cluster.pause()should pause every pool, whilecluster.resume()should resume every pool`cargo nextest run --profile devbash integration/go/run.sh